Merged
Conversation
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
This was referenced Jan 6, 2025
huard
approved these changes
Jan 8, 2025
Collaborator
huard
left a comment
huard
left a comment
There was a problem hiding this comment.
ax2 is there to get the right hand side axis. I was plotting the outline to make sure both ax and ax2 histogram matched. I think the changes I proposed retain the previous behavior but work with mpl 3.10
Co-authored-by: David Huard <huard.david@ouranos.ca>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
matplotlibfor v3.10+ compatibility.pygmentsto avoid a breaking change affectingsphinx-codeautolinkDoes this PR introduce a breaking change?
No.
Other information:
It's not entirely clear to me whether the dual histograms are being drawn properly to begin with. Alpha values from
axare the only ones that seem to matter when examining the graphic generated during tests.